Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human 1.15 #554

Merged
merged 137 commits into from
May 9, 2023
Merged

Human 1.15 #554

merged 137 commits into from
May 9, 2023

Conversation

haowang-bioinfo
Copy link
Member

@haowang-bioinfo haowang-bioinfo commented May 7, 2023

Main improvements in this PR:

haowang-bioinfo and others added 30 commits February 28, 2023 20:23
-Update GPRs for OXPHOS complexes II, IV, V according to Complex Portal annotation
fix: modify GPR rules of mitochondrial complexes II, IV, and V
- This is to address the issue reported in #495
- add Rhea ids to MAR04603, MAR04651, MAR04709, MAR04485, MAR04754
fix: consolidate subsystem of coenzyme A metabolism
- assign only NADK2 to MAR04268
- assign only NADK to MAR04269
- empty GPR to MAR04279
haowang-bioinfo and others added 18 commits April 30, 2023 10:20
- removed these fields from Yaml file
- disabled them in `importYaml` and `exportYaml` functions
Co-authored-by: Mihail Anton <mihail.anton@chalmers.se>
Co-authored-by: Mihail Anton <mihail.anton@chalmers.se>
…uration

style: move from lab-based development to community curation
- extract gene symbols from genes.tsv and include to Human-GEM
Co-authored-by: Mihail Anton <mihail.anton@chalmers.se>
fix: sedoheptulose kinase/phosphatase reactions
@haowang-bioinfo
Copy link
Member Author

Here's small scale essentiality evaluation of combined Hart2015 datasets (all), by reusing the code of Human1 paper.

version TP TN FP FN accuracy sensitivity specificity F1 MCC
v1.12 40 2333 175 77 0.904000000000000 0.341880341880342 0.930223285486443 0.240963855421687 0.204768560393159
v1.13 40 2334 174 77 0.904380952380952 0.341880341880342 0.930622009569378 0.241691842900302 0.205504558241293
v1.14 40 2334 175 77 0.904036557501904 0.341880341880342 0.930251096054205 0.240963855421687 0.204787829413435
v1.15 40 2342 168 77 0.906737723639132 0.341880341880342 0.933067729083665 0.246153846153846 0.210053956889428

Overall, the latest model shows good improvements in decreased false positive values and increased true negatives, which actually reversed a little bit after #551 compared to the result #390.

fix: remove orphan mets MAM02662c, MAM02662m,  MAM02662x
Copy link
Collaborator

@johan-gson johan-gson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haowang-bioinfo
Copy link
Member Author

haowang-bioinfo commented May 9, 2023

IMHO, several comments:

  1. forget about perfect, because being the best always delay things from getting better
  2. follow the rule of release early, release often - Eric S. Raymond
  3. therefore avoid too much curations (i.e. limit the number of PRs no more than 20 probably) for each release
  4. welcome critical comments from research community, because given enough eyes, all bugs are shallow

@haowang-bioinfo
Copy link
Member Author

#555 is now included to v1.15

@haowang-bioinfo haowang-bioinfo merged commit 30db9d9 into main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants